[PATCH] D150370: Introduce StructuredData

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Missing all the assembler tests (but I guess they come with the bitcode parts?)



================
Comment at: llvm/include/llvm/IR/StructuredData.h:70
+  Type *getType() const {
+    assert(isType());
+    return std::get<Type *>(S);
----------------
Does std::get on variant not do this for you?


================
Comment at: llvm/lib/IR/AsmWriter.cpp:1345
+    } else {
+      llvm_unreachable("unhandled sdata::Value type");
+    }
----------------
seems more like a report_fatal_error kind of case


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150370/new/

https://reviews.llvm.org/D150370