[PATCH] D152869: [nfc] Factoring out utility that can be used for other object-level tools

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/include/llvm/Object/ObjectFile.h:408
+  SectionFilterIterator(SectionFilterPredicate Pred,
+                        llvm::object::section_iterator const &Begin,
+                        llvm::object::section_iterator const &End)
----------------
jhenderson wrote:
> Since you're moving this code into the `llvm::object` namespace, I believe all these `llvm::object::` prefixes can disappear. Please do that.
> 
> It's also a good chance to tidy up some of the style issues. In particular, LLVM code prefers "west const" (i.e. the const before the type name).
> 
> These points apply thoughour the moved code.
> It's also a good chance to tidy up some of the style issues. In particular, LLVM code prefers "west const" (i.e. the const before the type name).

Please do this too (e.g. `const section_iterator &` rather than the current `section_iterator const &`). Also applies in a couple of places in this code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152869/new/

https://reviews.llvm.org/D152869