[PATCH] D153320: [XRay][AArch64] Suppport __xray_customevent/__xray_typedevent

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:343
+  O.emitLabel(CurSled);
+  MCInst MovX0Op0 = MCInstBuilder(AArch64::ADDXri)
+                        .addReg(AArch64::X0)
----------------
peter.smith wrote:
> IIUC these two instructions are `add x0, <rn>, #0` and `add x1, <rn>, #0` if the addend is always 0 then while this will work it isn't idiomatic. Would a mov instruction work? I think this may be an alias of the register form with one of the sources the zero register Xzr.
Yes, mov will work. I'll change...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153320/new/

https://reviews.llvm.org/D153320