[PATCH] D153007: [AMDGPU] Switch to the new cl option amdgpu-atomic-optimizer-strategy.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:867
             B.CreateIntrinsic(Intrinsic::amdgcn_strict_wwm, Ty, ExclScan);
-      } else {
+      } else if (ScanImpl == ScanOptions::Iterative) {
         LaneOffset = ExclScan;
----------------
pravinjagtap wrote:
> arsenm wrote:
> > So the pass behavior with none is to just crash?
> Execution will not reach here for `None` strategy. 
So then there's no point in changing it? either leave it or at else llvm_unreachable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153007/new/

https://reviews.llvm.org/D153007