[PATCH] D153382: [lld-macho][test] Make reloc-subtractor.s robust

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/test/MachO/reloc-subtractor.s:52
 
+.section __DATA,bar
+_minuend_1:
----------------
MaskRay wrote:
> smeenai wrote:
> > MaskRay wrote:
> > > smeenai wrote:
> > > > Is it important to repeat the `.section` directive?
> > > Yes, the above check lines test this...
> > > `# CHECK:       {{0*}}[[#%x, SUB1ADDR:]] l {{.*}} __DATA,bar _sub1`
> > > 
> > > 
> > I meant that we already have a `.section __DATA,bar` above `_sub1`, so do we need to issue that directive again here?
> Sorry, I missed this. I think this `.section __DATA,bar` directive can be removed.
Thanks, I pushed rGb1dadab3d9e3


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153382/new/

https://reviews.llvm.org/D153382