[PATCH] D153479: [NFC] Add tests for future commit in DAGCombiner

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 16:07:30 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/combine_andor_with_cmps.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 2
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1100 -verify-machineinstrs -stop-after=finalize-isel < %s | FileCheck %s
+
----------------
Why use mir for this?


================
Comment at: llvm/test/CodeGen/AMDGPU/combine_andor_with_cmps.ll:23
+}
+
+define i1 @test2(i32 %arg1, i32 %arg2) #0 {
----------------
Should also do some SGPR tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153479/new/

https://reviews.llvm.org/D153479



More information about the llvm-commits mailing list