[PATCH] D153435: [test] Add test for null_pointer_is_valid and Inliner instsimplify interaction

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 14:00:38 PDT 2023


aeubanks updated this revision to Diff 533387.
aeubanks added a comment.

add test where caller has null_pointer_is_valid but not callee
(vice versa is already tested to make sure it's not inlined)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153435/new/

https://reviews.llvm.org/D153435

Files:
  llvm/test/Transforms/Inline/instsimplify-null-pointer-is-valid.ll


Index: llvm/test/Transforms/Inline/instsimplify-null-pointer-is-valid.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/Inline/instsimplify-null-pointer-is-valid.ll
@@ -0,0 +1,41 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
+; RUN: opt -passes=inline < %s -S | FileCheck %s
+
+; Test that instsimplify invoked by the inliner respects null_pointer_is_valid
+; (by ensuring that the instruction is inserted into the function when invoking
+; instsimplify).
+
+define internal i1 @f(ptr %p) null_pointer_is_valid {
+  %g = getelementptr inbounds i8, ptr %p, i32 -1
+  %r = icmp eq ptr %g, null
+  ret i1 %r
+}
+
+define i1 @g(ptr %p) null_pointer_is_valid {
+; CHECK-LABEL: define i1 @g
+; CHECK-SAME: (ptr [[P:%.*]]) #[[ATTR0:[0-9]+]] {
+; CHECK-NEXT:    [[G_I:%.*]] = getelementptr inbounds i8, ptr [[P]], i32 -1
+; CHECK-NEXT:    [[R_I:%.*]] = icmp eq ptr [[G_I]], null
+; CHECK-NEXT:    ret i1 [[R_I]]
+;
+  %r = call i1 @f(ptr %p)
+  ret i1 %r
+}
+
+define internal i1 @f2(ptr %p) {
+  %g = getelementptr inbounds i8, ptr %p, i32 -1
+  %r = icmp eq ptr %g, null
+  ret i1 %r
+}
+
+define i1 @g2(ptr %p) null_pointer_is_valid {
+; CHECK-LABEL: define i1 @g2
+; CHECK-SAME: (ptr [[P:%.*]]) #[[ATTR0]] {
+; CHECK-NEXT:    [[G_I:%.*]] = getelementptr inbounds i8, ptr [[P]], i32 -1
+; CHECK-NEXT:    [[R_I:%.*]] = icmp eq ptr [[G_I]], null
+; CHECK-NEXT:    ret i1 [[R_I]]
+;
+  %r = call i1 @f2(ptr %p)
+  ret i1 %r
+}
+


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153435.533387.patch
Type: text/x-patch
Size: 1535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230621/b5a70168/attachment.bin>


More information about the llvm-commits mailing list