[PATCH] D153459: [DebugInfo] Add error handling to DWARFDebugAbbrev::getAbbreviationDeclarationSet

Alex Langford via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 12:53:31 PDT 2023


bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, fdeazeve, dblaikie, jhenderson.
Herald added subscribers: cmtice, hiraditya.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

This gives us more meaningful information when
`getAbbreviationDeclarationSet` fails. Right now only
`verifyAbbrevSection` actually uses the error that it returns, but the
other call sites could be rewritten to take advantage of the returned error.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153459

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugAbbrev.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugAbbrev.cpp
  llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/test/tools/llvm-dwarfdump/X86/empty-CU.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153459.533368.patch
Type: text/x-patch
Size: 5209 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230621/ff1e6b28/attachment.bin>


More information about the llvm-commits mailing list