[PATCH] D149888: [RISCV][SLP] Add tests for GEP costs in SLP

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM to the test additions in test/Analysis/CostModel/RISCV/gep-zero-indices.ll only.  The other piece needs a bit of cleanup, and is tied more to the sequence.



================
Comment at: llvm/test/Analysis/CostModel/RISCV/gep-zero-indices.ll:7
+
+; These GEPs should all cost zero becuase all the indice operands are zero, so
+; no computation actually needs to happen.
----------------
indices


================
Comment at: llvm/test/Transforms/SLPVectorizer/RISCV/gep.ll:5
+
+; FIXME: This should not be vectorized
+
----------------
This needs more explanation as to *why* this shouldn't be vectorized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149888/new/

https://reviews.llvm.org/D149888