[PATCH] D153437: [opt] Exposing the parameters of LoopRotate to the -passes interface

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:901
+Expected<std::pair<bool, bool>> parseLoopRotateOptions(StringRef Params) {
+  std::pair<bool, bool> Result = {false, false};
+  while (!Params.empty()) {
----------------
a bunch of tests are failing, probably because this should default to true to match the default constructor


================
Comment at: llvm/test/Other/new-pm-print-pipeline.ll:116
+; RUN: opt -disable-output -disable-verify -print-pipeline-passes -passes='function(loop(loop-rotate<no-header-duplication;no-perpare-for-lto>))' < %s | FileCheck %s --match-full-lines --check-prefixes=CHECK-33
+; CHECK-33: function(loop(loop-rotate<no-header-duplication;no-perpare-for-lto>))
----------------
typo


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153437/new/

https://reviews.llvm.org/D153437