[PATCH] D153164: [AArch64][GlobalISel] Select G_UADDE/G_SADDE/G_USUBE/G_SSUBE

[Tobias Stadler via Phabricator via llvm-commits]

tobias-stadler updated this revision to Diff 533289.
tobias-stadler added a comment.

Address comments. Thanks for the suggestions. I think the ifs and switches cleaned up quite nicely using the new helper classes.
My original train of thought behind the switch in emitCarryIn was that if anyone wanted to add support for carry-in setting of other instructions they would have to explicitly add their instruction and think about 
if they needed a negated carry and could opt-in to the optimizations only if they wanted to. I can't think of any other usecase though, so emitting the carry as-is also seems like a sane default.

Minor cleanup in PostSelectOptimize and added missed *Wrs variants of instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153164/new/

https://reviews.llvm.org/D153164

Files:
  llvm/include/llvm/CodeGen/GlobalISel/GenericMachineInstrs.h
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/lib/Target/AArch64/GISel/AArch64PostSelectOptimize.cpp
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-lse2.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-lse2_lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-outline_atomics.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-rcpc.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-rcpc3.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-v8_1a.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-v8a.ll
  llvm/test/CodeGen/AArch64/GlobalISel/postselectopt-dead-cc-defs-in-fcmp.mir
  llvm/test/CodeGen/AArch64/GlobalISel/postselectopt-dead-cc-defs.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-sadde.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-saddo.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-ssube.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-ssubo.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-uadde.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-uaddo.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-usube.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-usubo.mir
  llvm/test/CodeGen/AArch64/popcount.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153164.533289.patch
Type: text/x-patch
Size: 153613 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230621/f79017f2/attachment.bin>