[PATCH] D153268: [DWARFLinkerParallel] Add limited functionality to DWARFLinkerParallel.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 07:18:12 PDT 2023


avl added a comment.

In D153268#4436351 <https://reviews.llvm.org/D153268#4436351>, @clayborg wrote:

> In D153268#4436009 <https://reviews.llvm.org/D153268#4436009>, @avl wrote:
>
>> Another solution might be to use abbreviation table from already generated CU for the next CU. So that in any concrete moment current CU owns abbreviation table, but finally single abbreviation table would be shared between several CUs. That way, there still would exist several tables but some of them would be shared. It would reduce current size of .debug_abbrev.
>
> I like this idea. Not needed for this patch, but sounds like a good idea.

Though there is some difficulty with this solution. The binary content would be non-deterministic. As it can not be guaranteed which CU share which abbreviation table.

Do we need to preserve binary representation to be deterministic(byte to byte equal between runs)?

Probably we could use special dumping which would be deterministic? Like dumping from https://reviews.llvm.org/D124082. In spite of the fact that source files does not byte to byte equal - the contents of the dump would be byte to byte equal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153268/new/

https://reviews.llvm.org/D153268



More information about the llvm-commits mailing list