[PATCH] D153407: [lld][ARM] Add support for 16-bit thumb group relocations

Wed Jun 21 06:57:55 PDT 2023

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

One tiny nit aside, looks good to me. Please leave some time for MaskRay to take a look.

For reference: the R_ARM_THM_ALU_ABS_G* relocations are defined in the Static Thumb16 Relocations table https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst#5615static-thumb16-relocations .

================
Comment at: lld/ELF/Arch/ARM.cpp:686
+  case R_ARM_THM_ALU_ABS_G0_NC:
+    write16(loc, (read16(loc) &~ 0x00ff) | (val & 0xff));
+    break;
----------------
All the other uses of ~ in the file are of the form `& ~0x00ff` . Would be good to keep it consistent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153407/new/

https://reviews.llvm.org/D153407