[PATCH] D152558: [CodeGen] Extend reduction support in ComplexDeinterleaving pass to support predication

[Nicholas Guy via Phabricator via llvm-commits]

NickGuy accepted this revision.
NickGuy added a comment.
This revision is now accepted and ready to land.

LGTM, apart from a small point regarding variable names



================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:1731-1732
+
+  Instruction *MaskA, *MaskB;
+  Instruction *RA, *IA, *RB, *IB;
+  if (!match(Real, m_Select(m_Instruction(MaskA), m_Instruction(RA),
----------------
Nit: I think we use `AR/AI` rather than `RA/IA` elsewhere, probably best to remain consistent with this as much as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152558/new/

https://reviews.llvm.org/D152558