[PATCH] D153349: [AMDGPU] Preserve dom-tree analysis in atomic optimizer.

Wed Jun 21 04:59:27 PDT 2023

pravinjagtap added a comment.

In D153349#4437321 <https://reviews.llvm.org/D153349#4437321>, @arsenm wrote:

> In D153349#4437262 <https://reviews.llvm.org/D153349#4437262>, @pravinjagtap wrote:
>
>> In D153349#4437207 <https://reviews.llvm.org/D153349#4437207>, @arsenm wrote:
>>
>>> Why doesn’t this need an llc-pipeline or opt-pipeline update? Do we not have new PM pass testing?
>>
>> Atomic optimizer pass is not configured with opt and llc uses legacy PM which already preserve this analysis. Therefore opt/llc pipeline doesn't need update. I think, There is no test for NewPM with pre-codegen (IR) passes.
>
> We should have one. I thought we had an opt pipeline test but I don't see one, other targets do

I am not finding opt pipeline test for other targets. Can you please link it here. Interestingly, X86 and loongarch have filenames as opt-pipeline but these tests are invoking `llc` and not `opt`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153349/new/

https://reviews.llvm.org/D153349