[PATCH] D152998: [TableGen][RISCV] Support named arguments

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 02:57:14 PDT 2023


wangpc added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:120
   NewName = BinOpInit::getStrConcat(NewName, Name);
-  if (CurMultiClass && Scoper != "::") {
-    Init *Prefix = BinOpInit::getStrConcat(CurMultiClass->Rec.getNameInit(),
----------------
@nhaehnle
It seems that we can't define nested `class` in `multiclass`, so why do we need this?
Do you remember the context in D47431?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152998/new/

https://reviews.llvm.org/D152998



More information about the llvm-commits mailing list