[PATCH] D153204: RISCVAsmParser: support comments in more places

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 22:09:59 PDT 2023


MaskRay added a comment.

In D153204#4436782 <https://reviews.llvm.org/D153204#4436782>, @MaskRay wrote:

>> We spent a bit of time on the review of the original patch proposal for figuring out those things already. Cherry-pick my test at least :-D
>>
>> https://reviews.llvm.org/D153008
>
> If the important thing is to not miss "It has been reported by one of Esperanto's customers". I can mention this as well.

Note that I honestly thought "Reported by https://discourse.llvm.org/t/interleaving-several-c-style-comments-in-the-same-inline-assembly-line/71353" was sufficient.
Also, regarding the verboseness of the patch. I think this patch strikes a good balance, the other one has too many paragraphs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153204/new/

https://reviews.llvm.org/D153204



More information about the llvm-commits mailing list