[PATCH] D153204: RISCVAsmParser: support comments in more places

Tue Jun 20 17:49:34 PDT 2023

MaskRay added a comment.

Thank you for sharing your perspective. I understand your concern about taking over someone's work without their consent.
Though, it could be argued that the reporter posted a patch first, some might consider that others were just late in doing so, so technically a rework, not just "taking over" (unfortunately not independent due to chronological order).
In this particular case, the original patch had unrelated changes and test coverage issue after some review comments, which made it difficult to address the problem effectively.
As a community, I believe our primary goal is to ensure the quality and functionality of the codebase.
If people are familiar with me, they would know that I have invested significant effort in assisting others to improve their test writing. In many cases, it would save me a substantial amount of time, but I did not "take over".

However, I believe there is a cut-off point, and it would be more beneficial to demonstrate how to fix the issue for a few instances to effectively address this problem.
The patch I submitted was aimed at solving the specific issue at hand. I started from scratch, but I am happy to add Abel Bernabeu as a co-author.

For those who are not familiar with my background, I have been contributing to MC regularly since 2018.

This patch will address 5 out of the remaining 13 use cases. I believe it effectively tackles the most noticeable issues, but it would be beneficial to address the remaining 8 as well. However, I'm not in favor of a simple search/replace approach without code coverage (so I'd like to be removed as a co-author in D153008 <https://reviews.llvm.org/D153008>).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153204/new/

https://reviews.llvm.org/D153204