[PATCH] D149367: Emit the CodeView `S_ARMSWITCHTABLE` debug symbol for jump tables

[Daniel Paoliello via Phabricator via llvm-commits]

dpaoliello marked 2 inline comments as done.
dpaoliello added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1586
+  // Mark branches that may potentially be using jump tables with labels.
+  bool isThumb = Triple(MMI->getModule()->getTargetTriple()).getArch() ==
+                 llvm::Triple::ArchType::thumb;
----------------
efriedma wrote:
> Just to be on the safe side, I'd prefer to check for any arm/thumb target; I'm not sure we consistently end up with a "thumb" triple building for Thumb2.  (You can assume any 32-bit ARM code on Windows is Thumb2;  we don't support any targets other than windows 8/10.)
Per `mapArchToCVCPUType` (line 116 of this file), we only support `thumb` for ARM32 and any other value would result in a fatal error.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:38067
       // jmpq *TReg
+      assert(false);
       BuildMI(DispContBB, DL, TII->get(X86::JMP64r)).addReg(TReg);
----------------
efriedma wrote:
> Leftover debug code?
Yep, will remove.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149367/new/

https://reviews.llvm.org/D149367