[PATCH] D152944: [BOLT] Set IsRelro section attribute based on PT_GNU_RELRO segment

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits.



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:474
+      errs() << "BOLT-WARNING: GNU_RELRO segment has partial file offset "
+             << "overlap with section " << cantFail(SecRef.getName()) << '\n';
+      return;
----------------
nit: for consistency in messages, let's use `BinarySection->getName()`.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:479
+      errs() << "BOLT-WARNING: GNU_RELRO segment has partial VMA overlap with "
+             << "section " << cantFail(SecRef.getName()) << '\n';
+      return;
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152944/new/

https://reviews.llvm.org/D152944