[PATCH] D152745: [Docs] Update llvm-test-suite PGO instructions to use LLVM IR PGO by default

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/docs/TestSuiteGuide.md:354
 
+To use LLVM IR PGO instead of the clang frontend's PGO feature, set `-DTEST_SUITE_USE_IR_PGO=On`.
+
----------------
mingmingl wrote:
> aeubanks wrote:
> > mtrofin wrote:
> > > I would suggest either making `TEST_SUITE_USE_IR_PGO=On` default, or at minimum setting it to `On` in this example (e.g. line 340) and then flipping the comment on line 354.
> > +1, just change the default in llvm-test-suite and remove `-DTEST_SUITE_USE_IR_PGO=ON` from the docs
> Thanks for the input!
> 
> Given that front-end instrumentation (i.e., `fprofile-instr-generate`) is mentioned in user-manual (https://clang.llvm.org/docs/UsersManual.html#differences-between-sampling-and-instrumentation) and  [[ https://github.com/llvm/llvm-project/blob/6be2d599af2785c3c15652e95cfb0c8efb1e0229/llvm/cmake/modules/HandleLLVMOptions.cmake#L1107 | option-handling ]], I'm leaning towards keeping the default in case people rely on it in the daily testing workflow.
I thought we were trying to move away from `-fprofile-instr-generate` for any sort of PGO and only use it for code coverage, but that requires documentation updating


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152745/new/

https://reviews.llvm.org/D152745