[PATCH] D152328: InstrProf - don't emit 64 bit atomic operations on 32 bit platforms

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 14:53:03 PDT 2023


davidxl added a comment.

It might be better to handle this at the start of InstrProfiling::run (to override the Atomic related options with a proper warning).

Another thing is that what if an user wants to enable the emulated atomic update even when it is slow? You may want to introduce another internal option to control that : e.g. useAtomicEmulation (default to false). If it is true, do not override the option even when the target does not have hardware impl.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152328/new/

https://reviews.llvm.org/D152328



More information about the llvm-commits mailing list