[PATCH] D152944: [BOLT] Set IsRelro section attribute based on PT_GNU_RELRO segment

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 14:16:02 PDT 2023


maksfb added inline comments.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:476
+    BinarySection *BinarySection = BC->getSectionForSectionRef(SecRef);
+    if (!BinarySection || BinarySection->isTBSS())
+      continue;
----------------
I realized TBSS sections are specifically excluded from `isAllocatable()`. We are not interested in other non-allocatable sections either, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152944/new/

https://reviews.llvm.org/D152944



More information about the llvm-commits mailing list