[PATCH] D152945: [SystemZ][z/OS] Implement executePostLayoutBinding for GOFFWriter

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:81
+  ESD_ES_Part = 4
+};
+
----------------
I got some information from https://www.ibm.com/docs/en/zos/2.1.0?topic=formats-external-symbol-definition-record

X'00'
SD, section definition.

X'01'
ED, element definition. 

X'03' PR, part reference

X'04' ER and WX, external reference.

it look your enum member name and value do not same doc ?

do I use the wrong doc ?


================
Comment at: llvm/include/llvm/MC/MCAssembler.h:491
+
+  void setCsectNames(std::pair<std::string, std::string> Names) {
+    CsectNames = Names;
----------------
can we use const reference here for Name parameter ?

and I can not where the function be used ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152945/new/

https://reviews.llvm.org/D152945