[PATCH] D146776: [llvm] Preliminary fat-lto-objects support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for the update. This fixes `-DBUILD_SHARED_LIBS=on` build of mine.

Perhaps `llvm/test/Bitcode/` tests (which don't normally test `-passes=`) should be moved to elsewhere, e.g. `llvm/test/Transforms/EmbedBitcodePass/` ?

Another strange thing to fix:

`llc a.ll` => `.type   .Lllvm.embedded.object, at object`

We don't normally set attributes temporary symbols (`.L`) which do not normally have symbol table entries anyway.



================
Comment at: llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp:9
+//
+// EmbedBitcodePass implementation.
+//
----------------
If `EmbedBitcodePass.h` provides a descriptive comment, this comment can probably be removed. It does not give additional information to users:)


================
Comment at: llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp:42
+  std::unique_ptr<Module> NewModule = CloneModule(M);
+
+  MPM.run(*NewModule, AM);
----------------
delete unneeded blank line


================
Comment at: llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp:47
+  raw_string_ostream OS(Data);
+
+  if (IsThinLTO)
----------------
delete unneeded blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146776/new/

https://reviews.llvm.org/D146776