[PATCH] D153215: [Object] Add ELF section type SHT_LLVM_LTO for fat LTO
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 20 13:44:15 PDT 2023
MaskRay added a comment.
In D153215#4431926 <https://reviews.llvm.org/D153215#4431926>, @jhenderson wrote:
> Is it worth an llvm-objdump test too?
>
> Functionally looks fine, but I have no opinion on the overall feature itself (and therefore whether a new section type etc is needed for it).
>
> I will say that if the feature has been accepted, a new section type would seem appropriate, so that tooling can handle it appropriately without having to check section names.
I think normal code paths of `llvm-objdump` do not print section types. (`llvm-objdump -h` doesn't).
If there is an error, `llvm-objdump` will use `llvm::object::describe` to give an error, but the message is indirect. ``llvm::object::describe`` is tested by `llvm-readobj`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153215/new/
https://reviews.llvm.org/D153215
More information about the llvm-commits
mailing list