[PATCH] D152745: [Docs] Update llvm-test-suite PGO instructions to use LLVM IR PGO by default
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 20 12:51:13 PDT 2023
aeubanks added inline comments.
================
Comment at: llvm/docs/TestSuiteGuide.md:354
+To use LLVM IR PGO instead of the clang frontend's PGO feature, set `-DTEST_SUITE_USE_IR_PGO=On`.
+
----------------
mtrofin wrote:
> I would suggest either making `TEST_SUITE_USE_IR_PGO=On` default, or at minimum setting it to `On` in this example (e.g. line 340) and then flipping the comment on line 354.
+1, just change the default in llvm-test-suite and remove `-DTEST_SUITE_USE_IR_PGO=ON` from the docs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152745/new/
https://reviews.llvm.org/D152745
More information about the llvm-commits
mailing list