[PATCH] D147697: [IR] Add TargetExtTypeClass

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:738
+  SDATA_TYPE = 1,
+  SDATA_SYMBOL = 2,
+  SDATA_INT_BASE = 15, // add the bit size
----------------
nikic wrote:
> What is SDATA_SYMBOL used for, in the context of this patch? It doesn't look like the corresponding IR handling in D150370 supports this.
It isn't used yet. Symbols-as-values is something that I added when exploring how to put enums into metadata, and I didn't remove it here because it does seem useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147697/new/

https://reviews.llvm.org/D147697