[PATCH] D153165: Select `G_SADDE`, `G_UADDE`, `G_SSUBE` and `G_USUBE` for AArch64

Tue Jun 20 10:29:00 PDT 2023

aemerson added a comment.

In D153165#4430161 <https://reviews.llvm.org/D153165#4430161>, @niwinanto wrote:

> In D153165#4429338 <https://reviews.llvm.org/D153165#4429338>, @tobias-stadler wrote:
>
>> I fixed these same issues here https://reviews.llvm.org/D153164 2 minutes earlier. I do generate better code though, because I generate less instructions for carry-in setting and optimize these instructions away whenever possible. For >O0 I generate identical code to SelectionDag. I also have higher test coverage.
>
> Ohh cool. Insane coincidence. My plan was to support missing instructions, other wise it can cause internal compiler crashes. I did not touch the optimization, hence less optimized code is expected.

Insane indeed! By internal compiler crashes do you mean fallbacks? If so I generally don't class them as crashes (although certainly it's great to fix them).

Thanks for this work anyway, I'll review the other patch from @tobias-stadler

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153165/new/

https://reviews.llvm.org/D153165