[PATCH] D119049: [LLD] Allow usage of LLD as a library

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/unittests/AsLibELF/ROCm.cpp:33
+  llvm::SmallString<256> thisPath;
+  thisPath.append(getenv("LLD_SRC_DIR"));
+  llvm::sys::path::append(thisPath, "unittests", "AsLibELF");
----------------
>From what I can tell, this is a reinvention of `add_llvm_unittest_with_input_files()` which is discouraged because it entangle build and source data. The recommendation is to have a lit test for things that need to read in-tree things. Unit tests shouldn't affect the source directory. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049