[PATCH] D153247: [DAG] Fix and expand fmin/fmax reassociation fold.

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 09:30:42 PDT 2023


anna added a comment.

LGTM w/ a comment. Thanks for catching this!



================
Comment at: llvm/test/CodeGen/AArch64/double_reduct.ll:40
 ; CHECK-NEXT:    ret
   %r1 = call fast float @llvm.vector.reduce.fmin.v8f32(<8 x float> %a)
   %r2 = call fast float @llvm.vector.reduce.fmin.v4f32(<4 x float> %b)
----------------
Since we no longer check any flags for doing the reassociation, can you pls add a test without the `fast` flag as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153247/new/

https://reviews.llvm.org/D153247



More information about the llvm-commits mailing list