[PATCH] D153335: [ELFAttributeParser] Skip unknown vendor subsections.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

This looks correct to me. You may be able to reproduce the same behaviour with a more minimal yaml file.

A link to the relevant part of the Arm specification: https://github.com/ARM-software/abi-aa/blob/main/addenda32/addenda32.rst#325conformance-constraints . The compatibility is meant to be handled by https://github.com/ARM-software/abi-aa/blob/main/addenda32/addenda32.rst#3372generic-compatibility-tag

There is a list of registered vendors at https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst#registered-vendor-names but I think on the general principle that the ABI doesn't require compatibility checks for this section then it isn't worth checking that the vendor be part of the registered list.



================
Comment at: lld/test/ELF/Inputs/arm-vfp-arg-vfp-vendor.yaml:24
+Sections:
+  - Name:            .text
+    Type:            SHT_PROGBITS
----------------
May be able to remove the .text section and have no effect on the test.


================
Comment at: lld/test/ELF/Inputs/arm-vfp-arg-vfp-vendor.yaml:39
+      - Name:            .symtab
+Symbols:
+  - Name:            '$a.0'
----------------
Could probably get away with removing this part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153335/new/

https://reviews.llvm.org/D153335