[PATCH] D153261: [AMDGPU] Verify dom tree only when -verify-dom-info is passed.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 06:06:07 PDT 2023


arsenm added a comment.

In D153261#4434599 <https://reviews.llvm.org/D153261#4434599>, @yassingh wrote:

> Why aren't we preserving dom-tree if were are updating it?

It looks like it is reported as preserved in the old PM, but not the new



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:150
                  .run(F)
              ? PreservedAnalyses::none()
              : PreservedAnalyses::all();
----------------
This should be fixed to report the dominator tree is updated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153261/new/

https://reviews.llvm.org/D153261



More information about the llvm-commits mailing list