[PATCH] D147697: [IR] Add TargetExtTypeClass

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 04:51:05 PDT 2023


nhaehnle marked 2 inline comments as done.
nhaehnle added inline comments.


================
Comment at: llvm/test/Assembler/invalid-typeinfo.ll:51
+; CHECK: [[@LINE+1]]:40: error: expected '}' or field label here
+type target("foo") { layout: type i32, , canBeGlobal: true }
----------------
Flakebi wrote:
> What happens when adding a target type with the same name twice?
This should be accepted as long as there's no conflict in the type info. I'm adding a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147697/new/

https://reviews.llvm.org/D147697



More information about the llvm-commits mailing list