[PATCH] D153261: [AMDGPU] Verify dom tree only when -verify-dom-info is passed.

Tue Jun 20 03:27:50 PDT 2023

pravinjagtap added a comment.

In D153261#4432463 <https://reviews.llvm.org/D153261#4432463>, @arsenm wrote:

> In D153261#4432462 <https://reviews.llvm.org/D153261#4432462>, @pravinjagtap wrote:
>
>> In D153261#4432298 <https://reviews.llvm.org/D153261#4432298>, @foad wrote:
>>
>>> If `-verify-dom-info` is used then the normal analysis verification should catch this after this pass has run, as mentioned here: https://reviews.llvm.org/D147408#inline-1471284
>>>
>>> So I do not think you need any explicit calls to DominatorTree::verify
>>
>> Unfortunately No. The `-verify-dom-info` is not catching the un-updated dom tree.
>
> Is this just the analysis was dropped because nothing after it was using it problem? If you run the pass twice with -passes do you see the error?

Understood why dom-tree verifier was not catching the un-updated DT. After IR transformations in AtomicOptimizer Analyses results are invalidated (when IR is transformed) and verifier re-computes the dom-tree freshly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153261/new/

https://reviews.llvm.org/D153261