[PATCH] D151025: [llvm-exegesis] Add support for using memory annotations

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 01:06:42 PDT 2023


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-exegesis/X86/memory-annotations-livein.test:5
+
+# CHECK: measurements:
+# CHECK-NEXT: value: {{.*}}, per_snippet_value: {{.*}}
----------------
Can you add a comment to explain what the test checks ? Something like:

```
# This test check that we can use a combination of memory and register definitions.
```

Same for the other test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151025/new/

https://reviews.llvm.org/D151025



More information about the llvm-commits mailing list