[PATCH] D152794: [AMDGPU][GlobalISel] Shaders can only call amdgpu_gfx

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call.ll:5295
 
-define amdgpu_ps void @amdgpu_ps_call_default_cc() {
-  ; CHECK-LABEL: name: amdgpu_ps_call_default_cc
----------------
arsenm wrote:
> nhaehnle wrote:
> > arsenm wrote:
> > > This shouldn't be dropped
> > Do you have a better idea? We can't meaningfully support calls to C calling convention from shaders...
> What this was doing and passing undef to missing inputs
Okay fair enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152794/new/

https://reviews.llvm.org/D152794