[PATCH] D153280: [AMDGPU] Forbid dynamic alloca on PAL ABI

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 23:58:55 PDT 2023


nhaehnle added a comment.

I tend to agree with Matt here. *Current* graphics APIs don't allow users to write code that uses dynamic allocas, but since the stack size can be set externally there's no fundamental reason why supporting them should be impossible.

What I'd suggest here is that we beef up the llvm-dialects verifier support a little to make it possible to add custom verifier code, and then checking for non-entry allocas could be added to that verifier exclusively in the frontend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153280/new/

https://reviews.llvm.org/D153280



More information about the llvm-commits mailing list