[PATCH] D153106: [CSKY] Optimize multiplication with immediates
Ben Shi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 19 20:12:43 PDT 2023
benshi001 marked an inline comment as done.
benshi001 added inline comments.
================
Comment at: llvm/lib/Target/CSKY/CSKYSubtarget.h:210
+
+ unsigned getDataSizeInBits() const { return 32; }
};
----------------
zixuan-wu wrote:
> I think the name getDataSizeInBits is not precise about target machine.
>
> ```
> static const unsigned XLEN = 32;
> ```
>
> may be better?
I prefer `const unsigned XLen = 32;`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153106/new/
https://reviews.llvm.org/D153106
More information about the llvm-commits
mailing list