[PATCH] D153309: AMDGPU: Delete old AMDGPUPropagateAttributes pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: AMDGPU, rampitec, kzhuravl, lamb-j, Pierre-vh, b-sumner.
Herald added subscribers: foad, jdoerfert, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: sstefan1.
Herald added a project: LLVM.

The optimizing, non-broken features have all been moved to
AMDGPUAttributor. The only remaining piece of functionality was the
broken propagation of the wavesize features. This was fundamentally
broken and a hack for device library linking. It doesn't matter when
the device libraries are correctly linked and internalized.

      

In case of linked-as-normal-bitcode (as comgr still does), we're
reliant on the global subtarget anyway. If we can get away without
forcing target-cpu, we should just as well be able to get away without
propagating target-features.


https://reviews.llvm.org/D153309

Files:
  llvm/lib/Target/AMDGPU/AMDGPU.h
  llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  llvm/lib/Target/AMDGPU/CMakeLists.txt
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
  llvm/test/CodeGen/AMDGPU/propagate-attributes-clone.ll
  llvm/test/CodeGen/AMDGPU/propagate-attributes-function-pointer-argument.ll
  llvm/test/CodeGen/AMDGPU/propagate-attributes-single-set.ll
  llvm/utils/gn/secondary/llvm/lib/Target/AMDGPU/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153309.532762.patch
Type: text/x-patch
Size: 30402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230619/0f48e7cf/attachment.bin>