[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands
Abel Bernabeu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 19 15:14:37 PDT 2023
abel-bernabeu added a comment.
@jrtc27:
The tests:
- are under llvm/test/MC/RISCV
- use llvm-mc as assembler (rather than C!)
- are as simple as they can be
- cover every line touched by this patch.
Would you unblock this now? Thanks for your feedback so far.
@MaskRay:
Let me know if you miss any testing or places where comments are still not possible. Am pretty sure I am covering every case.
You have been added as coauthor here (with the standard "Co-Authored-By: " tag on the commit message) and you can close https://reviews.llvm.org/D153204 in return :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153008/new/
https://reviews.llvm.org/D153008
More information about the llvm-commits
mailing list