[PATCH] D151482: [LV] Add support for minimum/maximum intrinsics
Anna Thomas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 19 11:25:06 PDT 2023
anna added a comment.
In D151482#4432974 <https://reviews.llvm.org/D151482#4432974>, @anna wrote:
> Thanks @dmgreen. Will add the test and update the missing intrinsics in the `getMinMaxReductionPredicate ` API.
Confirmed interleaving does infact go through this API and crashes since the intrinsic support was missing. Updated the API, but also made the `createMinMaxOp` use the intrinsic itself rather than the Fcmp + Select pattern. So the `getMinMaxReductionPredicate` API is unused at this point for fminimum/fmaximum, but support is left in for completeness.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151482/new/
https://reviews.llvm.org/D151482
More information about the llvm-commits
mailing list