[PATCH] D153280: [AMDGPU] Forbid dynamic alloca on PAL ABI

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a reviewer: nhaehnle.
sebastian-ne added a comment.

> This is a bug, not an ABI constraint.

Unless the PAL ABI changes, there is no way for the compiler to tell the thing that allocates scratch (=PAL or the driver) that dynamically sized stack objects exist. That’s why I see this as an ABI constraint.
There is also no need for that because (as far as I am aware) no graphics API exposes the ability to create dynamically sized objects on the stack.

(+nhaehnle for more API knowledge, in case I’m forgetting something.)

> It looks like only the allocation side was implemented

Interesting. Maybe we should have an unconditional error then :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153280/new/

https://reviews.llvm.org/D153280