[PATCH] D153295: [AMDGPU] Do not release VGPRs if there may be pending scratch stores

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 09:54:23 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1422
+  if (TII->isFLATGlobal(MI))
+    return false;
+
----------------
gandhi21299 wrote:
> Shouldn't this return true?
It should be false but the comment should say never not always


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153295/new/

https://reviews.llvm.org/D153295



More information about the llvm-commits mailing list