[PATCH] D153279: [AMDGPU] Reimplement the GFX11 early release VGPRs optimization

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.s.buffer.load.ll:594
 ; GFX11-NEXT:    exp mrt0 v0, v0, v0, v0 done
+; GFX11-NEXT:    s_sendmsg sendmsg(MSG_DEALLOC_VGPRS)
 ; GFX11-NEXT:    s_endpgm
----------------
foad wrote:
> The old AMDGPUReleaseVGPRs pass did not send the message here because the `global_store_b32` above was not the last VGPR-using instruction before the `s_endpgm`. I don't understand why it was implemented that way. I think we do want to send the message, because VScnt might be non-zero here.
Yes, makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153279/new/

https://reviews.llvm.org/D153279