[PATCH] D153280: [AMDGPU] Forbid dynamic alloca on PAL ABI

Mon Jun 19 08:30:32 PDT 2023

arsenm added a comment.

In D153280#4432938 <https://reviews.llvm.org/D153280#4432938>, @arsenm wrote:

> In D153280#4432839 <https://reviews.llvm.org/D153280#4432839>, @sebastian-ne wrote:
>
>> Due to a bug in the compiler frontend, allocas got shifted into a non-entry block, which segfaulted in combination with D150609 <https://reviews.llvm.org/D150609>, therefore this patch to make sure nobody tries to use them.
>
> This is a bug, not an ABI constraint. Should fix the bug instead of producing an error.

It's also not PAL specific. OpenMP had the same out-of-entry bug before and reported crashes and nobody ever chased them down.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153280/new/

https://reviews.llvm.org/D153280