[PATCH] D152706: [AMDGPU] Use SSAUpdater in PromoteAlloca

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:568
+  // poison value.
+  Updater.AddAvailableValue(Alloca.getParent(), PoisonValue::get(VectorTy));
+
----------------
I think this is subtley wrong and should actually be undef. Alloca memory is currently initialized with undef, not poison


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152706/new/

https://reviews.llvm.org/D152706