[PATCH] D153180: [docs][TableGen][Target] Improve the documentation of the attribute value for SubtargetFeature.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 05:58:14 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/docs/WritingAnLLVMBackend.rst:1773
+attribute will be set to the maximum value of all enabled features that share
+the attribute.
+
----------------
craig.topper wrote:
> arsenm wrote:
> > Don't refer to it as an attribute, attributes are a separate thing entirely
> I was following the wording from the paragraph above and the .td. Should I change them all?
Yes. I think there's frequent confusion between "attributes" and subtarget features in "target-features"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153180/new/

https://reviews.llvm.org/D153180



More information about the llvm-commits mailing list