[PATCH] D153261: [AMDGPU] Verify dom tree only when -verify-dom-info is passed.
Pravin Jagtap via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 19 05:32:34 PDT 2023
pravinjagtap added a comment.
In D153261#4432298 <https://reviews.llvm.org/D153261#4432298>, @foad wrote:
> If `-verify-dom-info` is used then the normal analysis verification should catch this after this pass has run, as mentioned here: https://reviews.llvm.org/D147408#inline-1471284
>
> So I do not think you need any explicit calls to DominatorTree::verify
Unfortunately No. The `-verify-dom-info` is not catching the un-updated dom tree.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153261/new/
https://reviews.llvm.org/D153261
More information about the llvm-commits
mailing list