[PATCH] D153261: [AMDGPU] Assert only when -verify-dom-info is invoked.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 04:06:48 PDT 2023


arsenm added a comment.

Do we really need this intra-pass verification? With -verify-dom-info the DominatorTree verification should fail after the pass like normal



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:804
+    if (VerifyDomInfo)
+      assert(DTU.getDomTree().verify(DominatorTree::VerificationLevel::Full));
 
----------------
assert(!VerifyDomInfo || ....


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153261/new/

https://reviews.llvm.org/D153261



More information about the llvm-commits mailing list